feat: add wal latency metrics #40930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikos Angelopoulos <[email protected]>
github-actions
bot
requested review from
Aneurysm9,
ArthurSens,
dashpole,
rapphil and
ywwg
ArthurSens
reviewed
Jun 25, 2025
Comment on lines
298
to
299
| _, err = tel.GetMetric("otelcol_exporter_prometheusremotewrite_wal_read_latency") | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Shouldn't this be in TestWALRead_Telemetry?
There was a problem hiding this comment.
Yes you are right , fixed it d964aca
ArthurSens
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new histogram metrics to track the latency of Write-Ahead Log (WAL) operations in the Prometheus Remote Write Exporter:
otelcol_exporter_prometheusremotewrite_wal_write_latency: Tracks latency for WAL write operationsotelcol_exporter_prometheusremotewrite_wal_read_latency: Tracks latency for WAL read operationsLink to tracking issue
Part of #39556
Testing
Added UT
Documentation