[exporter/elasticsearch] Profiling: Duplicate events if count > 1 #40947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockdaboot
force-pushed
the
duplicate-events
branch
from
4fe660b to
7b322ea
Compare
crobert-1
approved these changes
Jun 26, 2025
|
See also elastic/elasticsearch#130293 |
dmathieu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to nanosecond timestamp resolution, the probability of events having a Stacktrace.count value > 1 is very low. For the rare cases where it is, we can write multiple identical events. The compression in Elasticsearch will handle this very well.
On the read/query side, things would be come less complex, and random sampling could be applied (requirement is that every event has the same "weight" aka count). Random sampling can reduce latency for queries.
Link to tracking issue
Fixes #40946