Skip to content

Change persistent queue to not use sized channel, improve memory usage and simplify sized_channel. #12060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner January 9, 2025 18:56
@bogdandrutu bogdandrutu requested a review from dmitryax January 9, 2025 18:56
@bogdandrutu bogdandrutu force-pushed the change-persistent-queue branch 4 times, most recently from f492e92 to 660fb92 Compare January 9, 2025 20:32
…e and simplify sized_channel.

Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu force-pushed the change-persistent-queue branch from 660fb92 to b2a43c9 Compare January 9, 2025 20:35
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 97.22222% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.67%. Comparing base (3132112) to head (b2a43c9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterqueue/persistent_queue.go 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12060      +/-   ##
==========================================
- Coverage   91.67%   91.67%   -0.01%     
==========================================
  Files         455      455              
  Lines       24038    24010      -28     
==========================================
- Hits        22037    22010      -27     
  Misses       1629     1629              
+ Partials      372      371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty clean! Thank you

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 10, 2025
Merged via the queue into open-telemetry:main with commit e6a5aee Jan 10, 2025
53 checks passed
@bogdandrutu bogdandrutu deleted the change-persistent-queue branch January 10, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants