-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[extension/extensionauth] Deprecate methods on Func types #12480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/extensionauth] Deprecate methods on Func types #12480
Conversation
1e7ee27
to
b44fee9
Compare
b44fee9
to
26f757d
Compare
Do you think this panic in contrib-tests is relevant? It looks to me like that test should have panicked even with the previous code however (creating an |
I added the nil check present in the Func types: 38d366c. I think that should solve the panic, thanks for pointing this out |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12480 +/- ##
==========================================
- Coverage 92.16% 92.05% -0.11%
==========================================
Files 465 467 +2
Lines 25201 25267 +66
==========================================
+ Hits 23226 23260 +34
- Misses 1576 1605 +29
- Partials 399 402 +3 ☔ View full report in Codecov by Sentry. |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follows #12480
Description
Depends on #12478, deprecates methods that are unnecessary