Skip to content

[service] Move batchprocessor metrics to normal level and update level guidelines #12525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Feb 28, 2025

Description

This PR:

  • requires "level: normal" before outputting batch processor metrics (in addition to one specific metric which was already restricted to "level: detailed")
  • clarifies wording in the telemetry level guidelines and documentation, and adds said guidelines to the requirements for stable components.

Some rationale for these changes can be found in the tracking issue and this comment.

Link to tracking issue

Resolves #7890

To be discussed

Should we add a feature gate for this, in case a user relies on "level: basic" outputting batch processor metrics? This feels like a niche use case, so considering the "alpha" stability level of these metrics, I don't think it's really necessary.

Considering batch processor metrics had already been switched to "normal" once (#9767), but were turned back to basic at some later point (not sure when), we might also want to add tests to avoid further regressions (especially as the handling of telemetry levels is bound to change further with #11754).

@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner February 28, 2025 11:32
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.02%. Comparing base (8099e51) to head (5fa6cec).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
service/service.go 83.33% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12525      +/-   ##
==========================================
- Coverage   92.15%   92.02%   -0.14%     
==========================================
  Files         465      470       +5     
  Lines       25183    25376     +193     
==========================================
+ Hits        23208    23351     +143     
- Misses       1576     1617      +41     
- Partials      399      408       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jade-guiton-dd!

@mx-psi mx-psi added this pull request to the merge queue Mar 4, 2025
Merged via the queue into open-telemetry:main with commit 1bb0469 Mar 4, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit how collector internal metric are distributed across telemetry levels
3 participants