Skip to content

Limiter extension interface: new admission limiter skeleton draft #12602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Mar 11, 2025

Description

This creates a skeleton for the proposed admission limiter based on the OTel-Arrow receiver's semaphore implementation, documented in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/otelarrowreceiver/README.md#admission-control-configuration..

Link to tracking issue

Part of #9591.

Testing

Added. This is only a skeleton.

Documentation

TODO.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (79a0331) to head (828cf71).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...sion/admissionlimiterextension/admissionlimiter.go 81.81% 2 Missing ⚠️
extension/admissionlimiterextension/config.go 80.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (90.90%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12602      +/-   ##
==========================================
- Coverage   92.18%   92.16%   -0.03%     
==========================================
  Files         469      475       +6     
  Lines       25394    25594     +200     
==========================================
+ Hits        23409    23588     +179     
- Misses       1574     1594      +20     
- Partials      411      412       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten codeboten changed the title Limiter extension interace: new admission limiter skeleton draft Limiter extension interface: new admission limiter skeleton draft Mar 12, 2025
@jmacd
Copy link
Contributor Author

jmacd commented Mar 12, 2025

See #12603 (comment).

@jmacd jmacd closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant