Introduce pprofile.PutAttribute helper

[rockdaboot]

Description

This introduces the pprofile.PutAttribute() helper method so profile extensions can modify attributes.

It replaces the yet unused pprofile.AddAttribute() function, as Add doesn't resonate well with the pcommon.Map Put* functions.

Additionally, the PutAttributes() helper takes into account the map k/v nature of attributes, while AddAttributes() didn't do this.

Testing

goos: linux
goarch: amd64
pkg: go.opentelemetry.io/collector/pdata/pprofile
cpu: 12th Gen Intel(R) Core(TM) i7-12800H
                                                          │   old.txt   │      new.txt       │
                                                          │   sec/op    │   sec/op     vs base   │
AddAttribute/with_a_new_string_attribute-20                 27.66n ± 3%
AddAttribute/with_an_existing_attribute-20                  27.18n ± 4%
AddAttribute/with_a_duplicate_attribute-20                  27.18n ± 2%
AddAttribute/with_a_hundred_attributes_to_loop_through-20   103.0n ± 4%
PutAttribute/with_a_new_string_attribute-20                               27.71n ± 2%
PutAttribute/with_an_existing_attribute-20                                28.14n ± 1%
PutAttribute/with_a_duplicate_attribute-20                                28.14n ± 2%
PutAttribute/with_a_hundred_attributes_to_loop_through-20                 28.15n ± 2%
geomean                                                     38.08n        28.04n       ? ¹ ²
¹ benchmark set differs from baseline; geomeans may not be comparable
² ratios must be >0 to compute geomean

                                                          │  old.txt   │      new.txt      │
                                                          │    B/op    │    B/op     vs base   │
AddAttribute/with_a_new_string_attribute-20                 16.00 ± 0%
AddAttribute/with_an_existing_attribute-20                  16.00 ± 0%
AddAttribute/with_a_duplicate_attribute-20                  16.00 ± 0%
AddAttribute/with_a_hundred_attributes_to_loop_through-20   16.00 ± 0%
PutAttribute/with_a_new_string_attribute-20                              16.00 ± 0%
PutAttribute/with_an_existing_attribute-20                               16.00 ± 0%
PutAttribute/with_a_duplicate_attribute-20                               16.00 ± 0%
PutAttribute/with_a_hundred_attributes_to_loop_through-20                16.00 ± 0%
geomean                                                     16.00        16.00       ? ¹ ²
¹ benchmark set differs from baseline; geomeans may not be comparable
² ratios must be >0 to compute geomean

                                                          │  old.txt   │      new.txt      │
                                                          │ allocs/op  │ allocs/op   vs base   │
AddAttribute/with_a_new_string_attribute-20                 1.000 ± 0%
AddAttribute/with_an_existing_attribute-20                  1.000 ± 0%
AddAttribute/with_a_duplicate_attribute-20                  1.000 ± 0%
AddAttribute/with_a_hundred_attributes_to_loop_through-20   1.000 ± 0%
PutAttribute/with_a_new_string_attribute-20                              1.000 ± 0%
PutAttribute/with_an_existing_attribute-20                               1.000 ± 0%
PutAttribute/with_a_duplicate_attribute-20                               1.000 ± 0%
PutAttribute/with_a_hundred_attributes_to_loop_through-20                1.000 ± 0%
geomean                                                     1.000        1.000       ? ¹ ²
¹ benchmark set differs from baseline; geomeans may not be comparable
² ratios must be >0 to compute geomean

See also #12390

[codecov]

Codecov Report

Attention: Patch coverage is 70.58824% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.58%. Comparing base (a867641) to head (c0079f8).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
pdata/pprofile/attributes.go	70.58%	10 Missing and 5 partials ⚠️

❌ Your patch status has failed because the patch coverage (70.58%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12798      +/-   ##
==========================================
- Coverage   91.61%   91.58%   -0.04%     
==========================================
  Files         505      505              
  Lines       28424    28475      +51     
==========================================
+ Hits        26042    26078      +36     
- Misses       1873     1883      +10     
- Partials      509      514       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dmathieu]

Additionally, the PutAttributes() helper takes into account the map k/v nature of attributes, while AddAttributes() didn't do this.

Could you describe that a bit more? (maybe in the changelog?) I find the motivation for this change hard to figure out.

[rockdaboot]

@bogdandrutu @dmitryax Can you please take a look?

[rockdaboot]

@bogdandrutu Are there any further concerns or can you merge this, please?

[mx-psi]

@bogdandrutu @dmitryax I will merge this by EOW if you do not object before then