-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Print generated resource attributes for internal logs #13111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13111 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 508 508
Lines 28736 28736
=======================================
Hits 26228 26228
Misses 1992 1992
Partials 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think there is a slight problem with your current solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nitpicks.
@open-telemetry/collector-maintainers can we merge this? Thank you! |
@open-telemetry/collector-maintainers can we merge this? Thanks! |
Signed-off-by: Israel Blancas <[email protected]>
…#13111) #### Link to tracking issue Fixes open-telemetry#13110 #### Testing - Improved the unit tests. Signed-off-by: Israel Blancas <[email protected]>
Link to tracking issue
Fixes #13110
Testing