Skip to content

Print generated resource attributes for internal logs #13111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

iblancasa
Copy link
Contributor

Link to tracking issue

Fixes #13110

Testing

  • Improved the unit tests.

@iblancasa iblancasa requested a review from a team as a code owner May 28, 2025 15:43
@iblancasa iblancasa requested a review from jade-guiton-dd May 28, 2025 15:43
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (8377ee7) to head (6d67e06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13111   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         508      508           
  Lines       28736    28736           
=======================================
  Hits        26228    26228           
  Misses       1992     1992           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think there is a slight problem with your current solution.

Copy link
Contributor

@jade-guiton-dd jade-guiton-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks.

@jade-guiton-dd jade-guiton-dd added the ready-to-merge Code review completed; ready to merge by maintainers label Jun 2, 2025
@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-maintainers can we merge this? Thank you!

@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-maintainers can we merge this? Thanks!

@bogdandrutu bogdandrutu enabled auto-merge June 4, 2025 17:59
@bogdandrutu bogdandrutu added this pull request to the merge queue Jun 4, 2025
Merged via the queue into open-telemetry:main with commit 698bf40 Jun 4, 2025
56 checks passed
malus2077 pushed a commit to malus2077/opentelemetry-collector that referenced this pull request Jun 5, 2025
…#13111)

#### Link to tracking issue
Fixes open-telemetry#13110

#### Testing
- Improved the unit tests.

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated resource attributes are missing from internal printed logs
3 participants