-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add testable examples to pdata module #13244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: How about move those examples into doc_test.go
separately, following https://github.com/open-telemetry/opentelemetry-collector/blob/main/confmap/doc_test.go
01646d4
to
c5b6a30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (86.45%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13244 +/- ##
==========================================
- Coverage 91.28% 86.45% -4.83%
==========================================
Files 511 524 +13
Lines 28802 31992 +3190
==========================================
+ Hits 26291 27660 +1369
- Misses 1994 3553 +1559
- Partials 517 779 +262 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c5b6a30
to
6d9f2ed
Compare
@bogdandrutu It seems that the code coverage is too low so I've added more examples to improve that. Please review it. |
6d9f2ed
to
480fd6e
Compare
@bogdandrutu Other workflow failures have been fixed. But the codecov workflow still failed although I've add more examples to improve the coverage. Actually I've test the coverage of |
I think you've been slighlyt mixing two things here. The code coverage low rate is something we can fix, but with new tests, not with new examples. |
I fully agree with you. Could you review this PR and re-run the CI pipeline, omitting the code coverage checks? |
The code coverage checks are non-blocking. They can't be skipped, but can fail and not prevent a PR from being merged. |
480fd6e
to
ea13a4d
Compare
Description
Add testable examples to pdata module. I've only started with the traces/metrics/logs examples.
Link to tracking issue
Feat #13145
Testing
Documentation