[pdata] Fix copying of optional fields when the source is unset #13268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
mx-psi,
dmathieu,
a team and
bogdandrutu
as code owners
dmitryax
force-pushed
the
pdata-fix-optional-fields-copy
branch
from
fe0ba90 to
8b2cc8b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13268 +/- ##
==========================================
- Coverage 91.59% 91.58% -0.01%
==========================================
Files 522 522
Lines 29145 29161 +16
==========================================
+ Hits 26695 26707 +12
- Misses 1933 1936 +3
- Partials 517 518 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitryax
added a commit
to dmitryax/opentelemetry-collector
that referenced
this pull request
Jun 26, 2025
dmitryax
force-pushed
the
pdata-fix-optional-fields-copy
branch
from
8b2cc8b to
d90fa7e
Compare
bogdandrutu
approved these changes
Jun 27, 2025
bogdandrutu
approved these changes
Jun 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
open-telemetry:main
with commit Jun 27, 2025
1440a98
58 of 59 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If destination has an optional field set to some value but source has it unset, we need to unset the field on the destination instead of keeping the old value.
Found this bug while working on #13267