Skip to content

chore(exporthelper): add debug level logging for startup and shutdown #13271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briangardner
Copy link

Description

Adds debug level logging to Startup and Shutdown operations in the Base Exporter.

Link to tracking issue

Fixes #10201

Testing

Tests were added to assert the debug logs are emitted.

@briangardner briangardner requested review from bogdandrutu, dmitryax and a team as code owners June 25, 2025 18:37
Copy link

linux-foundation-easycla bot commented Jun 25, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: briangardner / name: Brian Gardner (f11c11a)

@dmathieu
Copy link
Member

If we want data for this, why logs? Traces would much better catch what's happening.

@briangardner
Copy link
Author

If we want data for this, why logs? Traces would much better catch what's happening.

@dmathieu - If the exporter is failing to start, then it seems like logs are going to be easier to diagnose by looking at the agent logs on disk. Particularly for many of our customers who are not as familiar with OpenTelemetry.

Would you be opposed to leveraging both logs and traces?

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.61%. Comparing base (a33fdf3) to head (f11c11a).

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/base_exporter.go 84.61% 3 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (84.61%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13271      +/-   ##
==========================================
+ Coverage   91.57%   91.61%   +0.03%     
==========================================
  Files         522      522              
  Lines       29089    29107      +18     
==========================================
+ Hits        26639    26666      +27     
+ Misses       1933     1925       -8     
+ Partials      517      516       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be more observability around exporter helper start up and shutdown
2 participants