Skip to content

Record all possible sizes and handle legacy data migration #13274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Record all possible sizes and handle legacy data migration #13274

wants to merge 2 commits into from
+495 −318

Conversation

malus2077
Copy link
Contributor

What Changed

Core Implementation

  • Added requestsSize(), itemsSize(), bytesSize() methods for different size calculations
  • Enhanced internalSize() to support all sizer types with proper legacy handling
  • Introduced legacyWriteIndex field for backward compatibility during migration

Legacy Data Handling

  • Problem: Legacy queues lack BytesSize/ItemsSize historical data
  • Solution: Use legacyWriteIndex to track pre-migration items separately
  • Size calculation: modernSize + legacySize() during transition period

@malus2077 malus2077 requested review from bogdandrutu, dmitryax and a team as code owners June 26, 2025 21:50
@malus2077 malus2077 mentioned this pull request Jun 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@malus2077