Skip to content

Change Prometheus receiver to use the new components interfaces #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1515 into master will increase coverage by 0.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   91.33%   91.34%   +0.01%     
==========================================
  Files         240      240              
  Lines       16742    16744       +2     
==========================================
+ Hits        15291    15295       +4     
+ Misses       1046     1045       -1     
+ Partials      405      404       -1     
Impacted Files Coverage Δ
receiver/prometheusreceiver/factory.go 80.55% <90.00%> (+1.14%) ⬆️
receiver/prometheusreceiver/internal/ocastore.go 93.54% <100.00%> (ø)
...eceiver/prometheusreceiver/internal/transaction.go 94.94% <100.00%> (ø)
receiver/prometheusreceiver/metrics_receiver.go 79.54% <100.00%> (ø)
service/defaultcomponents/defaults.go 84.61% <100.00%> (ø)
translator/internaldata/resource_to_oc.go 85.41% <0.00%> (ø)
internal/internal.go 89.47% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d010f...b65ff27. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 9e70411 into open-telemetry:master Aug 7, 2020
@bogdandrutu bogdandrutu deleted the promrecv branch August 7, 2020 01:54
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants