Make receiver data delivery guarantees explicit #4262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4262 +/- ##
=======================================
Coverage 88.07% 88.07%
=======================================
Files 173 173
Lines 10188 10188
=======================================
Hits 8973 8973
Misses 975 975
Partials 240 240 Continue to review full report at Codecov.
|
codeboten
reviewed
Oct 25, 2021
Resolves open-telemetry#4261 We want to make this explicit and ensure all receivers follow this pattern. It is important for applications of the Collector where it is delivery guarantees are critical. The OTLP receiver correctly follows the guarantees. Other receivers may need to be audited to ensure compliance.
tigrannajaryan
force-pushed
the
receiver-guarantees
branch
from
b482879 to
7978b48
Compare
bogdandrutu
approved these changes
Oct 26, 2021
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-collector
that referenced
this pull request
Apr 18, 2023
This expands the delivery guarantees introduced for network-based receivers to receivers that use checkpointing. The purpose of the requirement is the same: to prevent data losses. See previous PR: open-telemetry#4262
tigrannajaryan
added a commit
to tigrannajaryan/opentelemetry-collector
that referenced
this pull request
Apr 18, 2023
This expands the delivery guarantees introduced for network-based receivers to receivers that use checkpointing. The purpose of the requirement is the same: to prevent data losses. See previous PR: open-telemetry#4262
dmitryax
pushed a commit
that referenced
this pull request
Apr 18, 2023
This expands the delivery guarantees introduced for network-based receivers to receivers that use checkpointing. The purpose of the requirement is the same: to prevent data losses. See previous PR: #4262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4261
We want to make this explicit and ensure all receivers follow this pattern.
It is important for applications of the Collector where it is delivery guarantees are critical.
The OTLP receiver correctly follows the guarantees. Other receivers may need to be audited
to ensure compliance.