remove workaround to ignore for errors when creating instruments #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
codeboten
changed the title
added 2 commits
October 4, 2023 07:56
This fixes open-telemetry#8346 Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rm-ignore-err
branch
from
cb0c3e5 to
26ed116
Compare
evan-bradley
approved these changes
Oct 4, 2023
sfc-gh-bdrutu
approved these changes
Oct 4, 2023
bogdandrutu
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround had been put in place because of a restriction on
/characters in the name of the instrument. This is no longer an issue. This PR fixes #8346Follows #8574