[CONFIGURATION] File configuration - misc model #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
50 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3504 +/- ##
==========================================
- Coverage 89.96% 89.94% -0.02%
==========================================
Files 219 219
Lines 7051 7051
==========================================
- Hits 6343 6341 -2
- Misses 708 710 +2 🚀 New features to boost your workflow:
|
dbarker
reviewed
Jun 30, 2025
|
|
||
| #pragma once | ||
|
|
||
| #include <map> |
dbarker
reviewed
Jun 30, 2025
| namespace configuration | ||
| { | ||
|
|
||
| enum enum_otlp_http_encoding : std::uint8_t |
There was a problem hiding this comment.
Consider adding a comment indicating the intended deviation from the style guide. Perhaps link to this #3467 (comment)?
dbarker
reviewed
Jun 30, 2025
|
|
||
| #pragma once | ||
|
|
||
| #include <map> |
dbarker
reviewed
Jun 30, 2025
| std::unique_ptr<AttributesConfiguration> attributes; | ||
| std::unique_ptr<DetectorsConfiguration> detectors; | ||
| std::string schema_url; | ||
| std::string attributes_list; |
There was a problem hiding this comment.
Is there a required notation for the string of attributes? "key=value;..." ?
dbarker
reviewed
Jun 30, 2025
|
|
||
| // YAML-SCHEMA: schema/resource.json | ||
| // YAML-NODE: AttributeNameValue | ||
| // FIXME: Name/Value/Type |
There was a problem hiding this comment.
Can you share more on the FIXME's? Will these be addressed in later PRs as part of the initial roll out of the yaml configuration feature or left for a later phase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2481
This is a partial fix, that implements supporting declarations.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes