-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(retry): update backoff to v5, fix the breaking changes in that version #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove unsupported fields in v5: MaxElapsedTime, Stop and Clock - Use time.Now() and time.Since() to manually track elapsed time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 283 283
Lines 24928 24910 -18
=======================================
- Hits 20401 20386 -15
+ Misses 4122 4119 -3
Partials 405 405 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is auto-generated from the templates here:
https://github.com/open-telemetry/opentelemetry-go/tree/main/internal/shared/otlp/retry
They need to be updated, and make generate
needs to be run locally.
MaxElapsedTime
,Stop
andClock
time.Now()
andtime.Since()
to manually track elapsed timeFix #6417