Skip to content

feat(retry): update backoff to v5, fix the breaking changes in that version #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 15, 2025

Conversation

yumosx
Copy link
Contributor

@yumosx yumosx commented Mar 7, 2025

  • Remove unsupported fields in v5: MaxElapsedTime, Stop and Clock
  • Use time.Now() and time.Since() to manually track elapsed time

Fix #6417

yumosx added 3 commits March 7, 2025 09:37
- Remove unsupported fields in v5: MaxElapsedTime, Stop and Clock
- Use time.Now() and time.Since() to manually track elapsed time
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (2b4e1a3) to head (ede8f90).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6419     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        283     283             
  Lines      24928   24910     -18     
=======================================
- Hits       20401   20386     -15     
+ Misses      4122    4119      -3     
  Partials     405     405             

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is auto-generated from the templates here:
https://github.com/open-telemetry/opentelemetry-go/tree/main/internal/shared/otlp/retry

They need to be updated, and make generate needs to be run locally.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 10, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Mar 15, 2025
@MrAlias MrAlias merged commit 11cea34 into open-telemetry:main Mar 15, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade cenkalti/backoff from v4 to v5
3 participants