Skip to content

chore: move functionality from internal/rawhelpers.go to attribute #6578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 10, 2025
Merged

chore: move functionality from internal/rawhelpers.go to attribute #6578

merged 6 commits into from
Apr 10, 2025

Conversation

igrucci
Copy link
Contributor

@igrucci igrucci commented Mar 29, 2025 •
edited by MrAlias
Loading

Resolve #6524

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 29, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@igrucci igrucci force-pushed the chore/move-rawhelpers branch from b2a6e51 to fe369ef Compare March 29, 2025 16:24
MrAlias
MrAlias reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution. Only feedback is the changelog entry is not needed and can be removed.

@igrucci @MrAlias
Update CHANGELOG.md
e856a8d 
Co-authored-by: Tyler Yahn <[email protected]>
@igrucci igrucci requested a review from MrAlias March 30, 2025 11:46
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 31, 2025
@dmathieu
Copy link
Member

dmathieu commented Apr 3, 2025

You need to fix the linter.

@MrAlias
Copy link
Contributor

MrAlias commented Apr 3, 2025

You need to fix the linter.

@igrucci you should be able to run make and it will resolve your issue.

@MrAlias MrAlias merged commit cc43e01 into open-telemetry:main Apr 10, 2025
28 of 29 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.

Move functionality from internal/rawhelpers.go to attribute
3 participants
@igrucci @dmathieu @MrAlias