Skip to content

add numpy dev dependency #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

add numpy dev dependency #1117

merged 1 commit into from
Jul 15, 2025
+1 −0

Conversation

jhills20
Copy link
Contributor

No description provided.

@jhills20 jhills20 requested a review from rm-openai July 15, 2025 00:40
@jhills20 jhills20 closed this Jul 15, 2025
@jhills20 jhills20 deleted the update_dev_dep branch July 15, 2025 00:41
@jhills20 jhills20 restored the update_dev_dep branch July 15, 2025 00:42
@jhills20 jhills20 reopened this Jul 15, 2025
@seratch
Copy link
Member

seratch commented Jul 15, 2025

Hi @jhills20, this project already has numpy here, and it is installed when you run make sync. Do you see a different necessity to have it in dev dependencies too?

@rm-openai rm-openai merged commit 1f2dc81 into main Jul 15, 2025
10 checks passed
@rm-openai rm-openai deleted the update_dev_dep branch July 15, 2025 00:50
@jhills20
Copy link
Contributor Author

hey @seratch its because we need it for realtime as well, the numpy dependency is only for the voice section but its needed for realtime as well. plus its not actually needed for the project dependencies but just for the examples

@seratch
Copy link
Member

seratch commented Jul 15, 2025

ok, thanks for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm-openai rm-openai rm-openai approved these changes

Assignees
No one assigned
Labels
feature:voice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhills20 @seratch @rm-openai