Skip to content

TBD: add support for lazily clinit of enum classes used in annotations #26414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Jul 21, 2025

This PR modifies the implementation for annotation parsing and handling such that it can be used by the JVMCI annotation mechanism in a way that avoids triggering class initialization for enum classes used in an annotation. This is an important use case for Native Image where unnecessary class initialization must be avoid at build time.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26414/head:pull/26414
$ git checkout pull/26414

Update a local copy of the PR:
$ git checkout pull/26414
$ git pull https://git.openjdk.org/jdk.git pull/26414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26414

View PR using the GUI difftool:
$ git pr show -t 26414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26414.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@dougxc The following labels will be automatically applied to this pull request:

  • core-libs
  • graal
  • hotspot-compiler
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@liach
Copy link
Member

liach commented Jul 21, 2025

I wonder if we must reuse the core reflection annotation parser - what's the context of this annotation parsing? Against live classes?

@dougxc
Copy link
Member Author

dougxc commented Jul 21, 2025

I wonder if we must reuse the core reflection annotation parser - what's the context of this annotation parsing? Against live classes?

Please ignore this draft PR for now. I've put it up for some discussion with the Native Image team and it's not clear we want to go this way. I'll provide more detail if/when I take this PR out of draft.

@dougxc dougxc force-pushed the ds/jvmci-annotations branch 2 times, most recently from c279b9d to 5da8482 Compare July 21, 2025 20:08
@dougxc dougxc force-pushed the ds/jvmci-annotations branch from 5da8482 to 63e7afc Compare July 22, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants