8362889: [GCC static analyzer] leak in libstringPlatformChars.c

[MBaesken]

This is reported by the gcc static analyzer (-fanalyzer); it is just test coding so not very critical but probably should still be adjusted .

/jdk/test/jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c:74:12: warning: leak of 'str' [CWE-401] [-Wanalyzer-malloc-leak]
   74 | return JNU_NewStringPlatform(env, str);

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362889: [GCC static analyzer] leak in libstringPlatformChars.c (Bug - P4)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26415/head:pull/26415
$ git checkout pull/26415

Update a local copy of the PR:
$ git checkout pull/26415
$ git pull https://git.openjdk.org/jdk.git pull/26415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26415

View PR using the GUI difftool:
$ git pr show -t 26415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26415.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362889: [GCC static analyzer] leak in libstringPlatformChars.c

Reviewed-by: rriggs, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 0735dc2: 8362846: Windows error reporting for dll_load doesn't check for a null buffer
• 79f9d8d: 8350050: Shenandoah: Disable and purge allocation pacing support
• 4994bd5: 8359965: Enable paired pushp and popp instruction usage for APX enabled CPUs
• ... and 21 more: https://git.openjdk.org/jdk/compare/15b5b54ac707ba0d4e473fd6eb02c38a8efe705c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (82db2480)
• 02: Full - Incremental (de4f7881)
• 01: Full - Incremental (e2f902f6)
• 00: Full (7d2eae0b)

[RogerRiggs]

looks good

[MBaesken]

Hi Roger, thanks for the review !

[dholmes-ora]

LGMT. Thanks

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 5160cfb.
Since your change was applied there have been 24 commits pushed to the master branch:

• 0735dc2: 8362846: Windows error reporting for dll_load doesn't check for a null buffer
• 79f9d8d: 8350050: Shenandoah: Disable and purge allocation pacing support
• 4994bd5: 8359965: Enable paired pushp and popp instruction usage for APX enabled CPUs
• ... and 21 more: https://git.openjdk.org/jdk/compare/15b5b54ac707ba0d4e473fd6eb02c38a8efe705c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 5160cfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.