8357682 : sun.security.provider.certpath.Builder#getMatchingPolicies always returns null

[koushikthirupattur]

The method sun.security.provider.certpath.Builder#getMatchingPolicies appears to have been intended as a lazy initialization of the matchingPolicies field of the Builder class. However it checks for "matchingPolicies != null" (presumably it should be "matchingPolicies == null") at the start, which is always false. Therefore the method always returns null and the intended optimization goes unused.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357682: sun.security.provider.certpath.Builder#getMatchingPolicies always returns null (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26418/head:pull/26418
$ git checkout pull/26418

Update a local copy of the PR:
$ git checkout pull/26418
$ git pull https://git.openjdk.org/jdk.git pull/26418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26418

View PR using the GUI difftool:
$ git pr show -t 26418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26418.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@koushikthirupattur This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357682: sun.security.provider.certpath.Builder#getMatchingPolicies always returns null

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 326 new commits pushed to the master branch:

• ad510fb: 8338977: Parallel: Improve heap resizing heuristics
• 2292246: 8350621: Code cache stops scheduling GC
• 03e9ea1: 8358530: Properties#list should warn against non-String values
• ... and 323 more: https://git.openjdk.org/jdk/compare/8ea544c33fc502208577249fb83544f8d876bc17...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@koushikthirupattur The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9e7508e1)
• 00: Full (861801a4)

[openjdk]

⚠️ @koushikthirupattur the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8357682
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push