8362972: C2 fails with unexpected node in SuperWord truncation: IsFiniteF, IsFiniteD

[haominw]

Same as https://bugs.openjdk.org/browse/JDK-8362171 , so I've added IsFiniteF, IsFiniteD to the assert switch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362972: C2 fails with unexpected node in SuperWord truncation: IsFiniteF, IsFiniteD (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26423/head:pull/26423
$ git checkout pull/26423

Update a local copy of the PR:
$ git checkout pull/26423
$ git pull https://git.openjdk.org/jdk.git pull/26423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26423

View PR using the GUI difftool:
$ git pr show -t 26423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26423.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wanghaomin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haominw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362972: C2 fails with unexpected node in SuperWord truncation: IsFiniteF, IsFiniteD

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• ce02836: 8363229: Parallel: Remove develop flag GCExpandToAllocateDelayMillis
• ac141c2: 8359419: AArch64: Relax min vector length to 32-bit for short vectors
• ed70910: 8347901: C2 should remove unused leaf / pure runtime calls
• ... and 1 more: https://git.openjdk.org/jdk/compare/c68697e1786fac37402b729d05a47b2f6296a86c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@haominw The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (19bb3fd0)

[TobiHartmann]

Hi @haominw, could you please add a regression test for this issue? Thanks.

[haominw]

Hi @haominw, could you please add a regression test for this issue? Thanks.

Hi, test/hotspot/jtreg/compiler/intrinsics/TestDoubleIsFinite.java and TestFloatIsFinite.java can trigger this issue. I encountered the issue while adding the matcher match(Set dst (CMoveI (Binary cop (CmpI (IsFiniteF op) zero)) (Binary src1 src2))); on riscv ad file.

[TobiHartmann]

We run these test regularly but we didn't observe the issue. Are you running with any non-default VM flags? Does it only reproduce on RISCV?

[haominw]

We run these test regularly but we didn't observe the issue. Are you running with any non-default VM flags? Does it only reproduce on RISCV?

Only adding a matcher like match(Set dst (CMoveI (Binary cop (CmpI (IsFiniteF op) zero)) (Binary src1 src2))); will trigger this issue. There are no issues with the default VM. I saw that IsInfinite has already been added to the non-truncating list, so I wanted to add IsFinite as well.

[TobiHartmann]

Okay, thanks for the details. The fix looks good to me.

[haominw]

@TobiHartmann Thanks. Could you push it?