-
Notifications
You must be signed in to change notification settings - Fork 165
8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
Thanks for the reviews @phohensee. /approval request Backport from jdk9 to jdk8 to fix test bug which cause test always fails with jvm option -Xcomp. Change has been verified locally, test-fix only, no risk. |
@sendaoYan |
GHA report several failures, all the failures are known CA issues, unrelated to this PR. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset. |
Hi all,
We found that the jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java always fails with jvm option -Xcomp, and the test bug which cause test fails has been fixed by JDK-8041924 in jdk9. So I want to backport JDK-8041924 to fix this test bug.
The problemlist do not needed to deal with. And jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java been touch by JDK-8157499, and JDK-8157499 can not backport to jdk8 cleanly and it's no necessary to backport jdk8. These two things make this PR can not backport from jdk9 to jdk8 cleanly.
Change has been verified locally, test-fix only, no risk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/670/head:pull/670
$ git checkout pull/670
Update a local copy of the PR:
$ git checkout pull/670
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/670/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 670
View PR using the GUI difftool:
$ git pr show -t 670
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/670.diff
Using Webrev
Link to Webrev Comment