feat: throw exception on problematic owner ference adding in dependent resources #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t resources Signed-off-by: Attila Mészáros <[email protected]>
metacosm
reviewed
Jan 9, 2024
| @@ -71,6 +74,30 @@ public static String getNameFor(Class<? extends Reconciler> reconcilerClass) { | |||
| return getDefaultNameFor(reconcilerClass); | |||
| } | |||
|
|
|||
| public static void checkIfCanAddOwnerReference(HasMetadata owner, HasMetadata resource) { | |||
| if (owner instanceof GenericKubernetesResource | |||
There was a problem hiding this comment.
Maybe we should move this code to the Fabric8 client?
There was a problem hiding this comment.
I would add it to addOwnerReference, personally.
There was a problem hiding this comment.
Should be part of HasMetadata#addOwnerReference.
The other suggested alternative would involve exposing the validation method and then calling that method within addOwnerReference too. I don't really see the value of exposing that method.
metacosm
approved these changes
Jan 9, 2024
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…t resources (#2190) Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…t resources (#2190) Signed-off-by: Attila Mészáros <[email protected]>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…t resources (#2190) Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.