Skip to content

run ldap tests on travis #2875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

run ldap tests on travis #2875

wants to merge 2 commits into from

Conversation

marutosi
Copy link
Contributor

No description provided.

@TeatroIO
Copy link

I've prepared a stage to preview changes. Open stage or view logs.

@NobodysNightmare
Copy link
Contributor

You are missing a description.

In the description you could for example explain why you removed the sudo: false tag and why this is a good idea in your opinion.

One consequence I know about: http://docs.travis-ci.com/user/workers/container-based-infrastructure/

But there are probably more consequences...

@myabc
Copy link
Contributor

myabc commented Apr 20, 2015

I'd be loath to move off the Travis container infrastructure.

@NobodysNightmare
Copy link
Contributor

If only your PR descriptions were as expressive as your tweets... https://twitter.com/marutosijp/status/590166516395413505

@marutosi
Copy link
Contributor Author

why you removed the sudo: false tag

ruby-ldap/ruby-net-ldap#196 (comment)

@NobodysNightmare
Copy link
Contributor

And still you fail to see which other consequences this has (e.g. it is no longer possible to run on travis containerized infrastructure).

And you point me to a comment that points someone else to a commit message that points to the log output of travis.

You see the layers of indirection here? I can already see you pointing someone else to your comment here, just to add another layer of indirection.

@floriank
Copy link
Contributor

This contains #2882 entirely, please see the discussion there for my suggestion on fixing the test instead of reintroducing the fixture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants