Skip to content

Feat: custom odpEventManager and odpSegmentManager #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2023
Merged

Feat: custom odpEventManager and odpSegmentManager #447

merged 4 commits into from
Feb 8, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 2, 2023 •
edited
Loading

Summary

  • Added functionality to allow user to pass custom ODPEventManager and odpSegmentManager.
  • parsing fetchQualifiedSegment graphql response in ODPSegmentclient.

Test plan

All tests should pass. Tested with FSC.

Issues

Dependencies

@mnoman09 mnoman09 requested a review from a team as a code owner February 2, 2023 14:27
@mnoman09 mnoman09 removed their assignment Feb 2, 2023
jaeopt
jaeopt approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeopt jaeopt closed this Feb 8, 2023
@jaeopt jaeopt reopened this Feb 8, 2023
@jaeopt
Copy link
Contributor

jaeopt commented Feb 8, 2023 •
edited
Loading

@mnoman09 The interface issue has been fixed with a new SNAPSHOT of java-sdk. We still have one unit test fail, expected after the change. This PR is force-closed since it'll be fixed it in a separate PR.

@jaeopt jaeopt merged commit b724e40 into master Feb 8, 2023
@jaeopt jaeopt deleted the mnoman/customODPManager branch February 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnoman09 @jaeopt @optimizely-codereview-bot @NomanShoaib