-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
ExtensionArrayExtending pandas with custom dtypes or arrays.Extending pandas with custom dtypes or arrays.Testingpandas testing functions or related to the test suitepandas testing functions or related to the test suitegood first issue
Milestone
Description
The tests in https://github.com/pandas-dev/pandas/blob/master/pandas/tests/extension/base/setitem.py seem to mainly operate on ExtensionArrays that are boxed in a Series.
It would be good to directly test ExtensionArray.setitem.
Some of these tests could be parametrized with something like
@pytest.fixture(params=[True, False])
def box(request):
"""Whether to box the data in a Series"""
return request.param
def test_setitem_scalar_series(self, data, box):
if box:
data = pd.Series(data)
data[0] = data[1
assert arr[0] == data[1]
others may have to be written separately.
Metadata
Metadata
Assignees
Labels
ExtensionArrayExtending pandas with custom dtypes or arrays.Extending pandas with custom dtypes or arrays.Testingpandas testing functions or related to the test suitepandas testing functions or related to the test suitegood first issue