BUG/DEPR: the deprecation of util.testing fails for direct imports

[jorisvandenbossche]

In [1]: from pandas.util.testing import assert_frame_equal  
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-1-79d99d902fdd> in <module>
----> 1 from pandas.util.testing import assert_frame_equal

ImportError: cannot import name 'assert_frame_equal' from 'pandas.util.testing' (/home/joris/scipy/pandas/pandas/util/testing/__init__.py)

It works when accessing from top-level import:

In [3]: pd.util.testing.assert_frame_equal
/home/joris/miniconda3/envs/dev/bin/ipython:1: FutureWarning: pandas._testing.assert_frame_equal is deprecated. Please use pandas.testing.assert_frame_equal instead.
  #!/home/joris/miniconda3/envs/dev/bin/python
Out[3]: <function pandas._testing.assert_frame_equal(left, right, check_dtype=True, check_index_type='equiv', check_column_type='equiv', check_frame_type=True, check_less_precise=False, check_names=True, by_blocks=False, check_exact=False, check_datetimelike_compat=False, check_categorical=True, check_like=False, obj='DataFrame')>

[jorisvandenbossche]

cc @TomAugspurger

[TomAugspurger]

Thanks, looking into it.

[TomAugspurger]

I think the easiest way to restore these is as references to the _DeprecatedModule items. Something like

# pandas/util/testing/__init__.py
testing = _DeprecatedModule("pandas._testing", "pandas.testing", _removals)

with warnings.catch_warnings():
    assert_frame_equal = testing.assert_frame_equal
    ...

[TomAugspurger]

Actually that doesn't work since the user doesn't see the warning...