Skip to content

Run Isort on tests/util single PR #23347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2018
Merged

Run Isort on tests/util single PR #23347

merged 3 commits into from
Oct 28, 2018

Conversation

thoo
Copy link
Contributor

@thoo thoo commented Oct 25, 2018 •
edited by jreback
Loading

@pep8speaks
Copy link

Hello @thoo! Thanks for submitting the PR.

@jreback jreback added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 26, 2018
jreback
jreback requested changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update setup.cfg needed?

@codecov
Copy link

codecov bot commented Oct 26, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a9ddafe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23347   +/-   ##
=========================================
  Coverage          ?   92.22%           
=========================================
  Files             ?      169           
  Lines             ?    51258           
  Branches          ?        0           
=========================================
  Hits              ?    47274           
  Misses            ?     3984           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.66% <ø> (?)
#single 42.23% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ddafe...fdc9de4. Read the comment docs.

@thoo thoo force-pushed the fix_import_format_util branch from 95c07f7 to 4437f13 Compare October 26, 2018 03:59
@thoo
Copy link
Contributor Author

thoo commented Oct 28, 2018

@jreback Could you also review this one? Thanks.

@jreback jreback merged commit 05be769 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks!

future PR's always merge master (as have had a lot of updates)

@thoo thoo mentioned this pull request Nov 4, 2018
Closed
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@thoo @tm9k1
Run Isort on tests/util single PR (pandas-dev#23347)
2212cab
@thoo thoo deleted the fix_import_format_util branch January 2, 2019 20:26
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Run Isort on tests/util single PR (pandas-dev#23347)
2e4f780
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@thoo @Pingviinituutti
Run Isort on tests/util single PR (pandas-dev#23347)
9e36ecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thoo @pep8speaks @jreback