CI: Fail tests on all builds for FutureWarning/DeprecationWarning from numpy or pyarrow #57813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
mroeschke
changed the title
lithomas1
approved these changes
Mar 12, 2024
| @@ -60,11 +60,9 @@ jobs: | |||
| - name: "Pypy" | |||
| env_file: actions-pypy-39.yaml | |||
| pattern: "not slow and not network and not single_cpu" | |||
| test_args: "--max-worker-restart 0" | |||
There was a problem hiding this comment.
Is this related, or is it just not needed and we can remove the whole test_args thing?
|
I think this may be a a little too cumbersome to do as we test downstream libraries and introduce our own deprecations that get reflected in those test so going to close for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we should necessarily limit this to just to nightly build of these libraries