Skip to content

TST(string dtype): Resolve xfails in test_from_dummies #60694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pandas/core/reshape/encoding.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,9 @@ def from_dummies(
The default category is the implied category when a value has none of the
listed categories specified with a one, i.e. if all dummies in a row are
zero. Can be a single value for all variables or a dict directly mapping
the default categories to a prefix of a variable.
the default categories to a prefix of a variable. The default category
will be coerced to the dtype of ``data.columns`` if such coercion is
lossless, and will raise otherwise.

Returns
-------
Expand Down
32 changes: 29 additions & 3 deletions pandas/tests/reshape/test_from_dummies.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,7 @@ def test_no_prefix_string_cats_default_category(
):
dummies = DataFrame({"a": [1, 0, 0], "b": [0, 1, 0]})
result = from_dummies(dummies, default_category=default_category)
expected = DataFrame(expected)
if using_infer_string:
expected[""] = expected[""].astype("str")
expected = DataFrame(expected, dtype=dummies.columns.dtype)
tm.assert_frame_equal(result, expected)


Expand Down Expand Up @@ -449,3 +447,31 @@ def test_maintain_original_index():
result = from_dummies(df)
expected = DataFrame({"": list("abca")}, index=list("abcd"))
tm.assert_frame_equal(result, expected)


def test_int_columns_with_float_default():
# https://github.com/pandas-dev/pandas/pull/60694
df = DataFrame(
{
3: [1, 0, 0],
4: [0, 1, 0],
},
)
with pytest.raises(ValueError, match="Trying to coerce float values to integers"):
from_dummies(df, default_category=0.5)


def test_object_dtype_preserved():
# https://github.com/pandas-dev/pandas/pull/60694
# When the input has object dtype, the result should as
# well even when infer_string is True.
df = DataFrame(
{
"x": [1, 0, 0],
"y": [0, 1, 0],
},
)
df.columns = df.columns.astype("object")
result = from_dummies(df, default_category="z")
expected = DataFrame({"": ["x", "y", "z"]}, dtype="object")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the dtype of expected.columns matter? i think it will change depending on using_string_dtype

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current way from_dummies behaves and is documented is to preserve object dtype columns, even when strings could have been inferred. This test ensures that remains true regardless of the value of using_string_dtype.

tm.assert_frame_equal(result, expected)
Loading