-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
String dtype: turn on by default #61722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
String dtype: turn on by default #61722
Conversation
cc @rhshadrach I remember you gave the feedback when CoW option was removed (actually removed, without ability to turn CoW off), that it might be good to keep the option working for some time? (so that if you run into issues, you can still turn it off temporarily) Shall we do that here? And if we do that:
|
Aside docstrings, the only tests that were failing are the ones with the minimum pyarrow dependency of 10.0.1. For our support window of 2 years, we can bump that to 12.0.1. If that helps, will move it to a separate PR. |
I would like to keep the option for users to switch back to the old string type if needed |
Any idea how many xfailed tests are specific to this? I saw some this morning, will see if I can address those. |
looks like 20 tests (76 with parametrization) are xfailed. At least some of these will be easy-but-tedious of updating |
Now that 2.3.0 is released, time to switch the default on main to prepare for a 3.0 release (and also such that people using nightlies get this)
I assume this might also still uncover some failing tests. And the docstrings will still fail for sure.