feat: Add additional values in info panel key-value element #2904
Conversation
|
I will reformat the title to use the proper commit message syntax. |
|
🚀 Thanks for opening this pull request! |
parse-github-assistant
bot
changed the title
📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The label |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/components/AggregationPanel/AggregationPanelComponents.js (1)
57-62: Improve accessibility and consider semantic markup.The current implementation uses spaces to separate multiple values, which may not be ideal for screen readers. Consider using semantic markup for better accessibility.
Consider using a more semantic approach:
- {values.map((val, idx) => ( - <React.Fragment key={idx}> - {idx > 0 && ' '} - {renderValue(val, idx)} - </React.Fragment> - ))} + <span role="list" aria-label="Values"> + {values.map((val, idx) => ( + <span key={idx} role="listitem"> + {idx > 0 && <span aria-hidden="true"> </span>} + {renderValue(val, idx)} + </span> + ))} + </span>This provides better semantic meaning and screen reader support.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/AggregationPanel/AggregationPanelComponents.js(1 hunks)
🔇 Additional comments (2)
src/components/AggregationPanel/AggregationPanelComponents.js (2)
7-7: LGTM: Clean destructuring syntax.The formatting change improves readability by destructuring props directly in the function signature.
28-28: LGTM: Copy functionality correctly updated for arrays.The change from copying a single value to joining all values with spaces is appropriate for the new array support.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
984-993: Minor wording nit – clarify dual use ofvalue+values.Consider adding a short inline comment explaining that when both
valueandvaluesare provided, the component rendersvaluefirst followed by the entries invalues, to avoid any ambiguity for readers skimming the example.No blocking issue, purely documentation clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md(3 hunks)src/components/AggregationPanel/AggregationPanelComponents.js(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/AggregationPanel/AggregationPanelComponents.js
🧰 Additional context used
🪛 LanguageTool
README.md
[style] ~949-~949: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ...| No | The value text to display. Can be an array of values. ...
(MISSING_IT_THERE)
🪛 markdownlint-cli2 (0.17.2)
README.md
949-949: Table column count
Expected: 5; Actual: 6; Too many cells, extra data will be missing
(MD056, table-column-count)
README.md
Outdated
| | `value` | String | Array | - | No | The value text to display. Can be an array of values. | | ||
| | `values` | Array | - | Yes | Additional values to display after `value`. Each item is an object with `value`, optional `url` and `isRelativeUrl`. | | ||
| | `url` | String | `undefined` | Yes | The URL that will be opened in a new browser tab when clicking on the value text. It can be set to an absolute URL or a relative URL in which case the base URL is `<PROTOCOL>://<HOST>/<MOUNT_PATH>/`. | | ||
| | `isRelativeUrl` | Boolean | `false` | Yes | Set this to `true` when linking to another dashboard page, in which case the base URL for the relative URL will be `<PROTOCOL>://<HOST>/<MOUNT_PATH>/apps/<APP_NAME>/`. | | ||
| | `style` | Object | - | Yes | The CSS style definition. | |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix Markdown table – too many columns due to un-escaped “|”.
The added value row now has 6 cells, which breaks the table rendering and triggers MD056.
Escape the internal pipe so it stays inside the “Type” cell and realign the columns.
-| `value` | String | Array | - | No | The value text to display. Can be an array of values. |
+| `value` | String\|Array | - | No | The value text to display. Can be an array of values. |This also removes the extra “Default” placeholder that was introduced by accident.
After the change markdownlint and LanguageTool warnings disappear and the table renders correctly.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | `value` | String | Array | - | No | The value text to display. Can be an array of values. | | |
| | `values` | Array | - | Yes | Additional values to display after `value`. Each item is an object with `value`, optional `url` and `isRelativeUrl`. | | |
| | `url` | String | `undefined` | Yes | The URL that will be opened in a new browser tab when clicking on the value text. It can be set to an absolute URL or a relative URL in which case the base URL is `<PROTOCOL>://<HOST>/<MOUNT_PATH>/`. | | |
| | `isRelativeUrl` | Boolean | `false` | Yes | Set this to `true` when linking to another dashboard page, in which case the base URL for the relative URL will be `<PROTOCOL>://<HOST>/<MOUNT_PATH>/apps/<APP_NAME>/`. | | |
| | `style` | Object | - | Yes | The CSS style definition. | | |
| | `value` | String\|Array | - | No | The value text to display. Can be an array of values. | | |
| | `values` | Array | - | Yes | Additional values to display after `value`. Each item is an object with `value`, optional `url` and `isRelativeUrl`. | | |
| | `url` | String | `undefined` | Yes | The URL that will be opened in a new browser tab when clicking on the value text. It can be set to an absolute URL or a relative URL in which case the base URL is `<PROTOCOL>://<HOST>/<MOUNT_PATH>/`. | | |
| | `isRelativeUrl` | Boolean | `false` | Yes | Set this to `true` when linking to another dashboard page, in which case the base URL for the relative URL will be `<PROTOCOL>://<HOST>/<MOUNT_PATH>/apps/<APP_NAME>/`. | | |
| | `style` | Object | - | Yes | The CSS style definition. | |
🧰 Tools
🪛 LanguageTool
[style] ~949-~949: To form a complete sentence, be sure to include a subject or ‘there’.
Context: ...| No | The value text to display. Can be an array of values. ...
(MISSING_IT_THERE)
🪛 markdownlint-cli2 (0.17.2)
949-949: Table column count
Expected: 5; Actual: 6; Too many cells, extra data will be missing
(MD056, table-column-count)
🤖 Prompt for AI Agents
In README.md around lines 949 to 953, the Markdown table for the `value` row has
an unescaped pipe character in the "Type" column, causing the row to split into
six cells and breaking the table layout. To fix this, escape the internal pipe
character within the "Type" cell by prefixing it with a backslash, and remove
the unintended extra "Default" column placeholder. Then realign the columns so
the table renders correctly and passes markdownlint checks.
mtrezza
changed the title
mtrezza
changed the title
values parameter
mtrezza
changed the title
values parametervalues parameter
mtrezza
changed the title
values parametervalues parameter
mtrezza
changed the title
values parameter
# [7.3.0-alpha.15](7.3.0-alpha.14...7.3.0-alpha.15) (2025-07-15) ### Features * Add additional values in info panel key-value element ([#2904](#2904)) ([a8f110e](a8f110e))
|
🎉 This change has been released in version 7.3.0-alpha.15 |
# [7.3.0](7.2.1...7.3.0) (2025-08-01) ### Bug Fixes * Changing "Relative dates" option of saved filter does not enable save button ([#2947](#2947)) ([4f4977d](4f4977d)) * Class object counters in sidebar not updating ([#2950](#2950)) ([0f1920b](0f1920b)) * Clicking linked pointer with Cmd key in view table doesn't open page in new browser tab ([#2902](#2902)) ([101b194](101b194)) * Fails to generate MFA code with CLI command `parse-dashboard --createMFA` ([#2883](#2883)) ([544df1f](544df1f)) * Gracefully fail when trying to get new features in latest version of dashboard ([#2880](#2880)) ([1969a0e](1969a0e)) * Header checkbox in data browser does not indicate when a few rows are selected ([#2957](#2957)) ([e4ab666](e4ab666)) * Hyperlink in Views table ignores `urlQuery` key ([#2926](#2926)) ([c5eedf4](c5eedf4)) * Incorrect table cell width in App Settings table ([#2933](#2933)) ([d46765b](d46765b)) * Info panel scroll-to-top setting not persistent across dashboard sessions ([#2938](#2938)) ([2b78087](2b78087)) * Invalid clipboard content for multi-cell copy in data browser ([#2882](#2882)) ([22a2065](22a2065)) * Legacy filters without `filterId` cannot be deleted in data browser ([#2946](#2946)) ([65df9d6](65df9d6)) * Legacy filters without `filterId` do not appear in sidebar ([#2945](#2945)) ([fde3769](fde3769)) * Modal text input can be resized smaller than its cell in Safari browser ([#2930](#2930)) ([82a0cdc](82a0cdc)) * Move settings button on data browser toolbar for better UI ([#2940](#2940)) ([c473ce6](c473ce6)) * Pagination footer bar hides rows in data browser ([#2879](#2879)) ([6bc2da8](6bc2da8)) * Race condition on info panel request shows info panel data not corresponding to selected cell ([#2909](#2909)) ([6f45bb3](6f45bb3)) * Saved legacy filter in data browser cannot be deleted or cloned ([#2944](#2944)) ([15da90d](15da90d)) * Saved legacy filter with classname in query cannot be deleted ([#2948](#2948)) ([05ee5b3](05ee5b3)) * Selected text in info panel cannot be copied using Ctrl+C ([#2951](#2951)) ([0164c19](0164c19)) * Views not sorted alphabetically in sidebar ([#2943](#2943)) ([4c81fe4](4c81fe4)) * Warning dialog is shown after executing script on selected rows ([#2899](#2899)) ([027f1ed](027f1ed)) ### Features * Add additional values in info panel key-value element ([#2904](#2904)) ([a8f110e](a8f110e)) * Add AI agent for natural language interaction with Parse Server ([#2954](#2954)) ([32bd6e8](32bd6e8)) * Add clipboard icon to copy value of key-value element in info panel ([#2871](#2871)) ([7862c42](7862c42)) * Add Cloud Function as data source for views with optional text or file upload ([#2939](#2939)) ([f5831c7](f5831c7)) * Add column freezing in data browser ([#2877](#2877)) ([29f4a88](29f4a88)) * Add custom data views with aggregation query ([#2888](#2888)) ([b1679db](b1679db)) * Add environment variable support for AI agent configuration ([#2956](#2956)) ([2ac9e7e](2ac9e7e)) * Add hyperlink support in Views table ([#2925](#2925)) ([06cfc11](06cfc11)) * Add inclusive date filters "is on or after", "is on or before" in data browser ([#2929](#2929)) ([c8d621b](c8d621b)) * Add quick-add button to array parameter in Cloud Config ([#2866](#2866)) ([e98ccb2](e98ccb2)) * Add row number column to data browser ([#2878](#2878)) ([c0aa407](c0aa407)) * Add Settings menu to scroll info panel to top when browsing through rows ([#2937](#2937)) ([f339cb8](f339cb8)) * Add support for "not equal to" filter for Boolean values in data browser and analytics explorer ([#2914](#2914)) ([d55b89c](d55b89c)) * Add support for `Image` type in View table to display images ([#2952](#2952)) ([6a6b1f0](6a6b1f0)) * Add type mismatch warning when quick-adding entry to Cloud Config array parameter ([#2875](#2875)) ([bb1837f](bb1837f)) * Add view edit icon to views list in sidebar ([#2901](#2901)) ([96e33b9](96e33b9)) * Allow editing filter without loading data in data browser ([#2949](#2949)) ([9623580](9623580)) * Allow editing saved filters in data browser ([#2942](#2942)) ([daaccaa](daaccaa)) * Allow freeform text view resizing in modal dialogs ([#2910](#2910)) ([1399162](1399162)) * Persist info panel visibility when navigating across classes in data browser ([#2908](#2908)) ([1a3610a](1a3610a)) * Prefetch info panel data with config options `prefetchObjects` and `prefetchStale` ([#2915](#2915)) ([54a8156](54a8156)) * Warn when leaving data browser page with selected rows ([#2887](#2887)) ([206ead1](206ead1)) ### Performance Improvements * Add config option `enableResourceCache` to cache dashboard resources locally for faster loading in additional browser tabs ([#2920](#2920)) ([41a4963](41a4963))
Summary
value,urlandisRelativeUrlTesting
npm testnpx eslint src/components/AggregationPanel/AggregationPanelComponents.jshttps://chatgpt.com/codex/tasks/task_e_68761033ec0c832d9b65c99cdae73723
Summary by CodeRabbit
New Features
Bug Fixes
Documentation