Skip to content

Trim out useless metadoc legacy #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

Trim out useless metadoc legacy #117

merged 2 commits into from
Jun 11, 2025

Conversation

Crell
Copy link
Collaborator

@Crell Crell commented Jun 11, 2025

This is mostly old PSR-2 justifications that have not been relevant for many years. There's no reason for us to carry that baggage around.

KorvinSzanto
KorvinSzanto approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@KorvinSzanto KorvinSzanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do wish we had a better way to number sections so we didn't lose links though I highly doubt there are any links to these that need to be preserved.

@Crell Crell merged commit efcc1f2 into php-fig:master Jun 11, 2025
@Crell Crell deleted the meta-trim branch June 11, 2025 13:08
GGOemea
GGOemea reviewed Jun 13, 2025
View reviewed changes
Copy link

@GGOemea GGOemea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GGOemea GGOemea GGOemea left review comments

@KorvinSzanto KorvinSzanto KorvinSzanto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Crell @KorvinSzanto @GGOemea