Skip to content

Replace all structure body comments with simple ellipsis #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

ravage84
Copy link
Contributor

@ravage84 ravage84 commented Jun 5, 2023

  • Capitalize beginning of all comments
  • No periods at the end of comments

As an alternative to #75.

- Capitalize beginning of all comments
- No periods at the end of comments

As an alternative to php-fig#75.
@Crell
Copy link
Collaborator

Crell commented Jun 6, 2023

An informal poll in the WG Discord overwhelmingly favored this version, so we'll go with it. Thanks.

@Crell Crell merged commit b540bfc into php-fig:master Jun 6, 2023
@ravage84 ravage84 deleted the ellipsis-comments branch June 6, 2023 16:25
vdelau added a commit to vdelau/per-coding-style that referenced this pull request May 13, 2025
In [PR 79](php-fig#79) all
comments where either replaced with ellipsis or capitalized. The
`// no break` comment however is used literally in various tools and
capitalizing this might lead to tooling regressions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants