Skip to content

Move curl-setopt constants to their own variablelist #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jul 20, 2024

This PR copies all the CURLOPT_* constants from the curl-setopt() page to a dedicated <variablelist> on the cURL constants page. The changes in the first commit were made using this script and the second (DocBook compliant markup) commit was made by going through the individual issues one by one in order for the docs to compile.

The constant descriptions removed in third commit (and probably a lot more) will be added in a follow-up PR once all the CURL* constants are documented.

There is more that could have been updated in this new file (e.g. adding tags, referencing groups of constants (e.g. CURLSSLOPT_*) instead of listing them individually, etc.) but this PR has lots of changes as it is. I will probably open follow-up PRs once all the CURL* constants are documented.

haszi added 4 commits July 20, 2024 15:16
@haszi haszi requested a review from Girgias July 20, 2024 14:32
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work!

I see a couple of existing issues, but those should be addressed later.

@Girgias Girgias merged commit b7d6aaa into php:master Jul 26, 2024
2 checks passed
@haszi haszi deleted the Move-curl-setopt-constants-to-their-own-variablelist branch July 26, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants