Skip to content

PHP 8.4: Document DOM deprecations #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions reference/dom/constants.xml
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@
<entry>0</entry>
<entry>
Error code not part of the DOM specification. Meant for PHP errors.
Deprecated as of PHP 8.4.0 because this is no longer used.
Prior to PHP 8.4.0, this was inconsistently used to indicate
our-of-memory situations.
</entry>
</row>
<row xml:id="constant.dom-index-size-err">
Expand Down
14 changes: 11 additions & 3 deletions reference/dom/domdocument.xml
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@
<term><varname>actualEncoding</varname></term>
<listitem>
<para>
<emphasis>Deprecated</emphasis>. Actual encoding of the document,
is a readonly equivalent to
<emphasis>Deprecated as of PHP 8.4.0</emphasis>.
Actual encoding of the document, is a readonly equivalent to
<varname linkend="domdocument.props.encoding">encoding</varname>.
</para>
</listitem>
Expand All @@ -202,7 +202,8 @@
<term><varname>config</varname></term>
<listitem>
<para>
<emphasis>Deprecated</emphasis>. Configuration used when
<emphasis>Deprecated as of PHP 8.4.0</emphasis>.
Configuration used when
<function>DOMDocument::normalizeDocument</function> is
invoked.
</para>
Expand Down Expand Up @@ -399,6 +400,13 @@
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
<varname>actualEncoding</varname> and
<varname>config</varname> are formally deprecated now.
</entry>
</row>
<row>
<entry>8.0.0</entry>
<entry>
Expand Down
43 changes: 32 additions & 11 deletions reference/dom/domentity.xml
Original file line number Diff line number Diff line change
Expand Up @@ -119,37 +119,58 @@
<term><varname>actualEncoding</varname></term>
<listitem>
<para>
An attribute specifying the encoding used for this entity at the
time of parsing, when it is an external parsed entity. This is
&null; if it is an entity from the internal subset or if it is not
known.
<emphasis>Deprecated as of PHP 8.4.0</emphasis>.
This has always been equal to &null;.
</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domentity.props.encoding">
<term><varname>encoding</varname></term>
<listitem>
<para>
An attribute specifying, as part of the text declaration, the
encoding of this entity, when it is an external parsed entity. This
is &null; otherwise.
<emphasis>Deprecated as of PHP 8.4.0</emphasis>.
This has always been equal to &null;.
</para>
</listitem>
</varlistentry>
<varlistentry xml:id="domentity.props.version">
<term><varname>version</varname></term>
<listitem>
<para>
An attribute specifying, as part of the text declaration, the
version number of this entity, when it is an external parsed
entity. This is &null; otherwise.
<emphasis>Deprecated as of PHP 8.4.0</emphasis>.
This has always been equal to &null;.
</para>
</listitem>
</varlistentry>
</variablelist>
</section>
<!-- }}} -->


<section role="changelog">
&reftitle.changelog;
<informaltable>
<tgroup cols="2">
<thead>
<row>
<entry>&Version;</entry>
<entry>&Description;</entry>
</row>
</thead>
<tbody>
<row>
<entry>8.4.0</entry>
<entry>
<varname>actualEncoding</varname>,
<varname>encoding</varname>, and
<varname>version</varname> are formally deprecated now because they have
always been equal to &null;.
</entry>
</row>
</tbody>
</tgroup>
</informaltable>
</section>

<!-- {{{ See also -->
<!--
<section role="seealso">
Expand Down