ext-oci8: `oci_new_descriptor()` triggers dynamic property deprecation

[derrabus]

Description

The following code:

https://github.com/doctrine/dbal/blob/e15d05d08172ceeb4f55066feed48d688fdb0250/src/Driver/OCI8/Statement.php#L75

Resulted in this output:

Creation of dynamic property OCILob::$descriptor is deprecated

https://github.com/doctrine/dbal/runs/6850136105?check_suite_focus=true

But I expected this output instead:

The piece of code that PHP complains about does not write any property directly but calls oci_new_descriptor() which is supposed to return a new OCILob instance. I don't feel like I could avoid the deprecation.

PHP Version

PHP 8.2-dev 13479ee

Operating System

Ubuntu 20.04

[adoy]

@derrabus Thanks. I started to work on a patch for your issue. I'm not a user of oci extension myself so if you have the oportunity to make sure the patch work and also to give some input on GH-8756, that would be appreciated.

[derrabus]

Thank you very much for working on this. I don't use that extension much myself either. I help maintaining Doctrine DBAL and this issue bubbled up in our CI. 🙈

But as far as I can tell, DBAL never accesses those properties (descriptor and collection) directly.

[adoy]

@derrabus Thanks. I'll wait for answers on the code review. Would it be possible for you to run your test suite on the branch with the current fix ?

[cmb69]

We need to test oci8 and pdo_oci in our CI; there is #8348, but that needs more work. I doubt that a setup on AppVeyor makes sense, since the latest Oracle XE download is almost 2GB, and it is not yet preinstalled.