Skip to content

Deprecate returning non-string values from a user output handler #18932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 7, 2025
Merged

Deprecate returning non-string values from a user output handler #18932

merged 15 commits into from
Jul 7, 2025
+603 −17

Conversation

DanielEScherzer
Copy link
Member

TimWolla
TimWolla reviewed Jun 24, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer marked this pull request as ready for review June 26, 2025 21:21
Girgias
Girgias reviewed Jun 27, 2025
View reviewed changes
@DanielEScherzer DanielEScherzer requested a review from Girgias July 1, 2025 22:54
@Girgias Girgias mentioned this pull request Jul 2, 2025
Merged
Girgias
Girgias reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this! I added a few comments and I think the reason you don't get the "correct" name for anonymous functions should be fixed with #19011

@DanielEScherzer DanielEScherzer force-pushed the output-handler-non-string branch from 8144c55 to 198a391 Compare July 3, 2025 19:07
@DanielEScherzer
Copy link
Member Author

Thank you for tackling this! I added a few comments and I think the reason you don't get the "correct" name for anonymous functions should be fixed with #19011

Rebased after that patch was merged and indeed the anonymous functions no longer just say "Closure::__invoke", 87756d7

@DanielEScherzer DanielEScherzer requested a review from Girgias July 5, 2025 19:53
Girgias
Girgias requested changes Jul 6, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits, but looks mostly good :)

@DanielEScherzer DanielEScherzer requested a review from Girgias July 6, 2025 18:36
@DanielEScherzer DanielEScherzer merged commit d8577d9 into php:master Jul 7, 2025
9 checks passed
@DanielEScherzer DanielEScherzer deleted the output-handler-non-string branch July 7, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla left review comments

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: session SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielEScherzer @TimWolla @Girgias