-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Make OPcache non-optional #18961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make OPcache non-optional #18961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion opcache is not always necessary and even may add troubles in some cases (e.g. routers and media servers). I know dune-hd used PHP in their firmwares. Very probably other players powered by MPD. Installing PHP on routers running under *WRT is a common practice.
Technically I don't see problems in the patch.
@dstogov do you remember what kind troubles it caused? Was it related to code size, memory usage, or something else? Note that the RFC forces opcache to be built and linked into the binary, but it doesn't set |
No. I wrote - "this may add troubles". In the best case this will just waste ~1MB of RAM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. The “Fix expectations in version string tests” commit can probably be committed independently.
3ccdd8c
to
5ca3330
Compare
Spun of #18660
RFC: https://wiki.php.net/rfc/make_opcache_required
Currently, OPcache is both a Zend extension and a PHP module, but it must be loaded as a Zend extension with
zend_extension=opcache.so
. The Zend extension then loads the PHP module. Also, OPcache can not be built statically.This PR makes the following changes:
Depends on #18939.