Skip to content

Make parameter $column_key optional in array_column() #18994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make parameter $column_key optional in array_column() #18994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4666,10 +4666,10 @@ PHP_FUNCTION(array_column)
zend_long index_long = 0;
bool index_is_null = 1;

ZEND_PARSE_PARAMETERS_START(2, 3)
ZEND_PARSE_PARAMETERS_START(1, 3)
Z_PARAM_ARRAY_HT(input)
Z_PARAM_STR_OR_LONG_OR_NULL(column_str, column_long, column_is_null)
Z_PARAM_OPTIONAL
Z_PARAM_STR_OR_LONG_OR_NULL(column_str, column_long, column_is_null)
Z_PARAM_STR_OR_LONG_OR_NULL(index_str, index_long, index_is_null)
ZEND_PARSE_PARAMETERS_END();

Expand Down
2 changes: 1 addition & 1 deletion ext/standard/basic_functions.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,7 +1737,7 @@ function array_count_values(array $array): array {}
* @compile-time-eval
* @refcount 1
*/
function array_column(array $array, int|string|null $column_key, int|string|null $index_key = null): array {}
function array_column(array $array, int|string|null $column_key = null, int|string|null $index_key = null): array {}

/**
* @compile-time-eval
Expand Down
4 changes: 2 additions & 2 deletions ext/standard/basic_functions_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions ext/standard/tests/array/array_column_skip_column_argument.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
--TEST--
parameter $column_key of array_column() is optional
--FILE--
<?php

$array = [['a'], ['b']];
var_dump(array_column($array, index_key: 0));

?>
--EXPECT--
array(2) {
["a"]=>
array(1) {
[0]=>
string(1) "a"
}
["b"]=>
array(1) {
[0]=>
string(1) "b"
}
}
Loading