Skip to content

Remove some dead code from EXIF extension. #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Dec 8, 2019

@KalleZ if the special symbol defined specially for you to debug?

@KalleZ
Copy link
Member

KalleZ commented Dec 8, 2019

It is fine to remove; I added the clause because at the time I only expected to temporarily disable the automatic offset guessing mode (as we do not have any of the builtin MAKERNOTE formats which require this -- They are all either Intel or Motorola).

As I doubt these will be used anytime in a near future its fine to remove, one can always go back in Git history and find the code, should it be needed.

@php-pulls php-pulls closed this in 761e8c7 Dec 8, 2019
@Girgias Girgias deleted the dead-code-exif branch December 8, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants