Skip to content

Make artifact format more obvious #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025
Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 1, 2025

When downloading artifacts, there should be a file extension displayed, so everyone knows what will be downloaded.

@@ -104,7 +104,7 @@ function Add-Package {
}
}
}
Add-Content "artifact=$artifact" -Path $env:GITHUB_OUTPUT -Encoding utf8
Add-Content "artifact=$artifact.zip" -Path $env:GITHUB_OUTPUT -Encoding utf8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously:

image

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 1, 2025

Hi @shivammathur, can you review?

@shivammathur shivammathur merged commit 3ee2b6e into php:master Jun 1, 2025
@mvorisek mvorisek deleted the patch-1 branch June 1, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants