Skip to content

feat: tyrael is no more #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Tyrael
Copy link
Contributor

@Tyrael Tyrael commented Nov 28, 2024

remove myself from the list of trusted devs as I'm not contributing anymore

@php-pulls
Copy link

php-pulls commented Nov 28, 2024 via email

@cmb69
Copy link
Member

cmb69 commented Nov 29, 2024

@derickr, we also don't pose as @php-pulls. ;)

I find the rest of the commit message more concerning, anyway. For a moment that sounded like a bereavment.

@Tyrael, I'm fine with the removal, but it doesn't matter much nowadays, since the bug tracker does no longer accept new tickets for a while.

@derickr
Copy link
Member

derickr commented Nov 29, 2024 via email

@cmb69
Copy link
Member

cmb69 commented Nov 29, 2024

Yes, I know. No worries. :)

Personally, I find these tags ("feat", "chore", etc.) more than useless if not consitently applied, but I don't really mind (I see the old "MFH" commits all the time; that's worse).

@Tyrael
Copy link
Contributor Author

Tyrael commented Nov 29, 2024

yeah it's called Conventional Commits, nowadays I have the habbit of using them, I can reword the commit message, but you can also just squash it with whatever commit message you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants