syntax was updated to PHP 5.6 (::class string, short array syntax etc.) #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was added PHPUnit to dev-dependencies tests were updated to remove deprecations (please double-check it!!!) + BONUS: was added PHPStan to dev-dependencies it can help us to make better code and in future we can run it before tests to analyze code :) And finally joke: I think that CndParserTest is here (in this package) so that i made this refactoring I wan't to mark it as skipped in the end but I was very surprised :-D :-D
|
awsome, thanks! |
|
Ok, thank you too. I'm working on it in PHPCR-api-tests I will do that :-) What do you think about increase min PHP version to 5.6 in PHPCR-api-tests? I would like to add phpunit 5.7 and remove deprecations :) |
|
absolutely, lets bump it there as well
Am 21.01.2017 5:11 nachm. schrieb "Pavel Vondrášek" <
[email protected]>:
… Ok, thank you too. I'm working on it in PHPCR-api-tests I will do that :-)
What do you think about increase min PHP version to 5.6 in
PHPCR-api-tests? I would like to add phpunit 5.7 and remove deprecations :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAErIKl0krRqjsTWjE9gmL5twVIM_8bBks5rUi4agaJpZM4Lp4Oy>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was added PHPUnit to dev-dependencies
tests were updated to remove deprecations (please double-check it!!!)
And finally joke: I think that CndParserTest is here (in this package) so that i made this refactoring I wan't to mark it as skipped in the end but I was very surprised :-D :-D