Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Use snake_case consistently for prop names #958

@alexcjohnson

Description

@alexcjohnson

We've developed quite a melange of capitalizations in our prop names. Let's standardize on snake_case for everything in this repo. Our consensus is the only exception to this rule should be when we direct our users to the documentation of the underlying library rather than documenting all the props and their values ourselves. But that doesn't apply to anything in DCC.

Each component should do this in a backward-compatible way: first look for class_name, if that's missing look for className, only if both are missing use the default value. The original case should remain in propTypes, documented with Obsolete: use class_name instead.

Along with this we'll need to address #703 (avoid ramda.omit for forwarding props) because that problem will get much worse as a result.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions