-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Supporting reversed ranges in 3d scenes (final) #3141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
875067b
fixes for reversed bounds in 3d scenes
archmoj 5e4b75b
syntax, removed white spaces
archmoj d338aa3
including changes to gl-axes3d which is in gl-plot3d
archmoj e65f346
using new version of gl-axes3d
archmoj ab18276
gl-axis3d fix
archmoj 95aa008
added json mocks to collect test images
archmoj 60ee80d
refactoring if statements in shaders and scene
archmoj 7fa34f6
mocks to generate baseline images with CircleCi
archmoj 0414976
removed spaces from json mocks
archmoj f65b388
fixed a syntax error in json streamtubes mock and added one png baseline
archmoj 2a72dac
added streamtube baseline image
archmoj a8d0dab
using glslify for out-of-bound function
archmoj 1b1a827
correct streamtubes and cones translation
archmoj 292d34b
reformat json mocks
archmoj 7fc8f23
using npm new module glsl-out-of-range v 1.0.1
archmoj a77b9fd
using glsl-out-of-range v. 1.0.2 from a plotly repo
archmoj 8eb570a
resolved conflict with latest gl-plot3d and gl-axes3d
archmoj b0c1cba
updated baseline images with axes alignments only - ticks would be al…
archmoj f646d3f
using latest gl-vis modules
archmoj 373a03a
resolved conflicts
archmoj b37f4e3
update package lock
archmoj b295633
reset baseline images
archmoj adfe19d
updated baseline images to include tick new alignments
archmoj 1b08a4c
correct version for gl-mesh3d
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+105 KB
...aselines/gl3d_mesh3d_surface3d_scatter3d_line3d_error3d_log_reversed_ranges.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
147 changes: 147 additions & 0 deletions
147
test/image/mocks/gl3d_cone-newplot_reversed_ranges.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"x": [ | ||
0.2 | ||
], | ||
"y": [ | ||
0.4 | ||
], | ||
"z": [ | ||
-0.6 | ||
], | ||
"u": [ | ||
1 | ||
], | ||
"v": [ | ||
1 | ||
], | ||
"w": [ | ||
0 | ||
], | ||
"type": "cone" | ||
}, | ||
{ | ||
"x": [ | ||
0.4 | ||
], | ||
"y": [ | ||
-0.6 | ||
], | ||
"z": [ | ||
0.2 | ||
], | ||
"u": [ | ||
1 | ||
], | ||
"v": [ | ||
0 | ||
], | ||
"w": [ | ||
1 | ||
], | ||
"type": "cone" | ||
}, | ||
{ | ||
"x": [ | ||
-0.6 | ||
], | ||
"y": [ | ||
0.2 | ||
], | ||
"z": [ | ||
0.4 | ||
], | ||
"u": [ | ||
0 | ||
], | ||
"v": [ | ||
1 | ||
], | ||
"w": [ | ||
1 | ||
], | ||
"type": "cone" | ||
}, | ||
{ | ||
"x": [ | ||
-0.2 | ||
], | ||
"y": [ | ||
-0.4 | ||
], | ||
"z": [ | ||
0.6 | ||
], | ||
"u": [ | ||
-1 | ||
], | ||
"v": [ | ||
-1 | ||
], | ||
"w": [ | ||
0 | ||
], | ||
"type": "cone" | ||
}, | ||
{ | ||
"x": [ | ||
-0.4 | ||
], | ||
"y": [ | ||
0.6 | ||
], | ||
"z": [ | ||
-0.2 | ||
], | ||
"u": [ | ||
-1 | ||
], | ||
"v": [ | ||
0 | ||
], | ||
"w": [ | ||
-1 | ||
], | ||
"type": "cone" | ||
}, | ||
{ | ||
"x": [ | ||
0.6 | ||
], | ||
"y": [ | ||
-0.2 | ||
], | ||
"z": [ | ||
-0.4 | ||
], | ||
"u": [ | ||
0 | ||
], | ||
"v": [ | ||
-1 | ||
], | ||
"w": [ | ||
-1 | ||
], | ||
"type": "cone" | ||
} | ||
], | ||
"layout": { | ||
"height": 758, | ||
"width": 1310, | ||
"title": "Cone objects with Y-axis using autorange: 'reversed'", | ||
"scene": { | ||
"yaxis": { | ||
"autorange": "reversed" | ||
}, | ||
"camera": { | ||
"eye": { | ||
"x": 1, | ||
"y": -1.5, | ||
"z": 1.25 | ||
} | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.