-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Switch geodata providers #7393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
e8d763d
Add new dev dependencies
camdecoster 7f7b690
Add build scripts
camdecoster 6b596c0
Update some topojson references
camdecoster 353bf94
Add npm build scripts
camdecoster fc6022f
Add 'usa' config
camdecoster 2910eea
Add clipping bounds for Antarctica
camdecoster 5d66dad
Apply suggestions from code review
camdecoster 3b47c67
Add geodata archive, update get_geodata script paths
camdecoster b434656
Switch config file to JS
camdecoster a4d0b21
Switch coastlines layer source
camdecoster e257b7b
Add Oceania clipping bounds
camdecoster 1154ff1
Switch layer name to 'ocean'
camdecoster 86d5b00
Update test config
camdecoster 86f048c
Switch to UN/NE geodata hybrid
camdecoster ac61095
Merge remote-tracking branch 'origin/master' into cam/7334/switch-geo…
camdecoster f4c3d48
Fix zip/unzip of UN geojson
camdecoster 22a8e0a
Fix saving 110m maps
camdecoster 247f925
Update dist with new maps
camdecoster 3cf9730
Update geo tests
camdecoster 24e8558
Update cibuild npm script
camdecoster b2ae532
Add draftlog
camdecoster 85ad69c
Remove sane-topojson package
camdecoster b903b9f
Add small fixes
camdecoster e74c65c
Remove log statements
camdecoster 33a2e00
add some mocks to blacklist
emilykl 4868250
update baselines for new geodata
emilykl bce8d21
update blacklist in compare_pixels_test
emilykl da44084
Save UN geodata in build folder
camdecoster 69f104e
make sure slash is added when concatenating topojson path
emilykl c684b72
use local topojson for image tests
emilykl 362233a
update paths in jasmine geo_test
emilykl 4d37b8c
filter out extra features
emilykl bb8377b
update image baselines for new geodata
emilykl 6356355
Merge pull request #7406 from plotly/cam/7334/switch-geodata-provider…
emilykl 5482adf
Filter out extra Hawaii feature during processing
camdecoster 2710e7c
Revert "filter out extra features"
camdecoster b8bfea6
Adjust world rectangle to account for coordinate issues
camdecoster d6ea8ab
Fix Anarctica geometry and simplification
camdecoster 3ec56ab
Fix land layer, clean up comments
camdecoster 79017d5
Remove unused filter
camdecoster 0f9049c
Remove turf simplify
camdecoster 4a6fb9d
Update topojson
camdecoster 33d3425
Filter Greenland out of Europe
camdecoster c74f711
Erase Caspian Sea
camdecoster f7cdc5f
Update topojson
camdecoster 9711ef7
Update country codes for disputed territories at Egypt/Sudan border
camdecoster 51a596e
Update topojson
camdecoster 40968da
Merge remote-tracking branch 'origin/master' into cam/7334/switch-geo…
camdecoster 5e7efc8
Attempt to stitch antimeridian crossing polygons
camdecoster 9026b55
Remove rectangle geojson
camdecoster 597ae5c
Remove unneeded library; restore old library version
camdecoster 15dd77a
Correct polygon winding directions
camdecoster e385014
Update topojson
camdecoster d3940c6
Merge remote-tracking branch 'origin/master' into cam/7334/switch-geo…
camdecoster d7d7d0b
Fix merge issues with package-lock
camdecoster eb1e966
Update required dev dependencies again
camdecoster 60171d7
Split out antimeridian fixes
camdecoster 90554a2
Update topojson
camdecoster d836db9
Update test baseline images
camdecoster 3ddc6e0
Update geo tests
camdecoster f952173
Fix comment
camdecoster 75e9f52
Further update geo tests
camdecoster 3a7bd66
Update geo test with values from CircleCI
camdecoster a6efc84
Fix linting/formatting of new JS files
camdecoster 4f4bbfc
Merge remote-tracking branch 'origin/master' into cam/7334/switch-geo…
camdecoster 434017f
Revert to previous version of 'd3-geo'
camdecoster 9a4a966
Refactor helper function
camdecoster 1f336e1
Update draftlog
camdecoster 1bd2fc2
Update test baselines
camdecoster 6dae5aa
Move topojson build script files
camdecoster 665c892
Update paths
camdecoster ae3c471
Add topojson package files
camdecoster a2cce65
Add maps to topojson dist
camdecoster 7112d33
Update library paths
camdecoster 6e25a5f
Restore previous topojson
camdecoster ecd469f
Remove scripts, dependencies from package.json
camdecoster 50377f8
Add topojson ci build comparison test
camdecoster 601ffc9
Actually run test job in ci
camdecoster 0f3e102
Add npm clean script
camdecoster 9b62be0
Update path; remove comment
camdecoster 0539623
Update package lock file
camdecoster fc3978c
Add default scopes for Antarctica, Oceania
camdecoster b050574
Clarify comment
camdecoster e9c16c8
Add Egypt/Sudan choropleth mock
camdecoster fcaef12
Add test baseline image
camdecoster 36f5fb5
Update schema
camdecoster 765b549
Rename image/mock to avoid bug
camdecoster 8944398
Rename shadowed variable
camdecoster 7410c34
Update mock to include disputed regions
camdecoster 5b3e36c
Update CDN publish script to add '_un' suffix to topojson files
camdecoster 9cbd6c6
Update baseline image
camdecoster 9d2aa71
Temporarily comment out Antarctica, Oceania maps
camdecoster 0d6b5b7
Revert unnecessary test changes
camdecoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Switch to United Nations (coastlines, countries, land, ocean) + Natural Earth (lakes, rivers, subunits) geodata for building topojson used in geo plot |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ | |
"@plotly/d3-sankey": "0.7.2", | ||
"@plotly/d3-sankey-circular": "0.33.1", | ||
"@plotly/mapbox-gl": "1.13.4", | ||
"@plotly/regl": "^2.1.2", | ||
"@turf/area": "^7.1.0", | ||
"@turf/bbox": "^7.1.0", | ||
"@turf/centroid": "^7.1.0", | ||
|
@@ -105,7 +106,6 @@ | |
"point-in-polygon": "^1.1.0", | ||
"polybooljs": "^1.2.2", | ||
"probe-image-size": "^7.2.3", | ||
"@plotly/regl": "^2.1.2", | ||
"regl-error2d": "^2.0.12", | ||
"regl-line2d": "^3.1.3", | ||
"regl-scatter2d": "^3.3.1", | ||
|
@@ -121,6 +121,8 @@ | |
}, | ||
"devDependencies": { | ||
"@biomejs/biome": "1.8.3", | ||
"@plotly/mathjax-v2": "npm:[email protected]", | ||
"@plotly/mathjax-v3": "npm:mathjax@^3.2.2", | ||
"amdefine": "^1.0.1", | ||
"assert": "^2.1.0", | ||
"browserify-transform-tools": "^1.7.0", | ||
|
@@ -160,8 +162,6 @@ | |
"karma-viewport": "1.0.2", | ||
"lodash": "^4.17.21", | ||
"madge": "^8.0.0", | ||
"@plotly/mathjax-v2": "npm:[email protected]", | ||
"@plotly/mathjax-v3": "npm:mathjax@^3.2.2", | ||
"minify-stream": "^2.1.0", | ||
"npm-link-check": "^5.0.1", | ||
"open": "^8.4.2", | ||
|
@@ -171,7 +171,6 @@ | |
"raw-loader": "^4.0.2", | ||
"read-last-lines": "^1.8.0", | ||
"run-series": "^1.1.9", | ||
"sane-topojson": "^4.0.0", | ||
"sass": "^1.78.0", | ||
"stream-browserify": "^3.0.0", | ||
"style-loader": "^4.0.0", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,28 @@ | ||
'use strict'; | ||
|
||
var saneTopojson = require('sane-topojson'); | ||
// TODO: Remove comments from Antarctica, Oceania during new maps release PR | ||
const topojson = { | ||
africa_110m: require('../../dist/topojson/africa_110m.json'), | ||
// antarctica_110m: require('../../dist/topojson/antarctica_110m.json'), | ||
asia_110m: require('../../dist/topojson/asia_110m.json'), | ||
europe_110m: require('../../dist/topojson/europe_110m.json'), | ||
'north-america_110m': require('../../dist/topojson/north-america_110m.json'), | ||
// oceania_110m: require('../../dist/topojson/oceania_110m.json'), | ||
'south-america_110m': require('../../dist/topojson/south-america_110m.json'), | ||
usa_110m: require('../../dist/topojson/usa_110m.json'), | ||
world_110m: require('../../dist/topojson/world_110m.json'), | ||
africa_50m: require('../../dist/topojson/africa_50m.json'), | ||
// antarctica_50m: require('../../dist/topojson/antarctica_50m.json'), | ||
asia_50m: require('../../dist/topojson/asia_50m.json'), | ||
europe_50m: require('../../dist/topojson/europe_50m.json'), | ||
'north-america_50m': require('../../dist/topojson/north-america_50m.json'), | ||
// oceania_50m: require('../../dist/topojson/oceania_50m.json'), | ||
'south-america_50m': require('../../dist/topojson/south-america_50m.json'), | ||
usa_50m: require('../../dist/topojson/usa_50m.json'), | ||
world_50m: require('../../dist/topojson/world_50m.json'), | ||
} | ||
|
||
|
||
exports.version = require('../version').version; | ||
|
||
exports.topojson = saneTopojson; | ||
module.exports = { | ||
topojson, | ||
archmoj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
version: require('../version').version | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+5.36 KB
(100%)
test/image/baselines/geo_visible_false_override_template.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+471 Bytes
(100%)
test/image/baselines/h-colorbar_geo_multiple-usa-choropleths.png
Oops, something went wrong.
Binary file modified
BIN
+411 Bytes
(100%)
test/image/baselines/h-colorbar_geo_multiple-usa-choropleths_with-border.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"type": "choropleth", | ||
"name": "Egypt", | ||
"locations": ["EGY"], | ||
"z": [1], | ||
"colorscale": [[0, "orange"], [1, "orange"]], | ||
"showscale": false, | ||
"showlegend": true | ||
}, | ||
{ | ||
"type": "choropleth", | ||
"name": "Sudan", | ||
"locations": ["SDN"], | ||
"z": [1], | ||
"colorscale": [[0, "green"], [1, "green"]], | ||
"showscale": false, | ||
"showlegend": true | ||
}, | ||
{ | ||
"type": "choropleth", | ||
"name": "Disputed", | ||
"locations": ["XHT", "XBT"], | ||
"z": [1, 1], | ||
"colorscale": [[0, "red"], [1, "red"]], | ||
"showscale": false, | ||
"showlegend": true | ||
} | ||
], | ||
"layout": { | ||
"title": { | ||
"text": "Used 'XHT' and 'XBT' country codes to show disputed regions between Egypt and Sudan" | ||
}, | ||
"geo": { | ||
"showocean": true, | ||
"projection": { | ||
"rotation": { | ||
"lon": 30, | ||
"lat": 20 | ||
}, | ||
"scale": 7 | ||
} | ||
}, | ||
"width": 800, | ||
"height": 600 | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.