Skip to content

Fix Persian calendar leap year #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 14, 2025
Merged

Fix Persian calendar leap year #7456

merged 6 commits into from
Jul 14, 2025

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 4, 2025

Fixes #7421 in world-calendars dependency. See plotly/world-calendars#1.
Added tests.

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Jul 8, 2025
@archmoj archmoj requested a review from alexcjohnson July 11, 2025 16:41
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 That's a very complete test, nicely written!

@archmoj archmoj merged commit 021289c into master Jul 14, 2025
6 checks passed
@archmoj archmoj deleted the persian-leap-year branch July 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixes something broken P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persian calendar leap year issue
3 participants